Repository navigation
feat(WO17): py golden additivity gate + constraint class-context port (rs/ts parity) - #841
Merged
Merged
Conversation
…port Step 2 of the improvement round, two pieces: - tests/test_golden_capture.py: the PERMANENT golden additivity test for interscript-py (mirror of rs tests/golden_capture.rs and ts test/golden-isc-wf0.test.ts): parse the sibling maps/libs corpus, compile, replay all 12,337 golden rows byte-identically; adopting manifest honored; sibling-gated skip (GOLDEN_ROOT override). Harness detection proven against a doctored golden (one flipped row -> failure names exactly that map). - The rs/ts constraint fix lands in the py runtime: compile_item gains class_ctx — constraint positions (before/not_before/after/not_after) and any() alias arguments compile in CLASS context, where an IMPORTED charset alias resolving to a string expands per-character (rs convert_class_alias; local string aliases stay sequences). Without it the ell lookbehinds compiled from a ~400-char literal sequence and could never match, silently disabling alalc-ell's medial gamma rules. 4 regression specs watched failing first (root-cause shape, from-any single char, local-alias sequence preservation, the five ell rows + the word-final gk guard through the in-process path). Verified: golden 12,337/12,337 byte-identical through the in-process py runtime (83 s; pre-fix exactly 5 divergent rows, all alalc-ell-Grek-Latn-2010); constraint/wf1/parser suites green.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WO17 step 2a — two pieces for interscript-py:
tests/test_golden_capture.py, mirror of rstests/golden_capture.rsand tstest/golden-isc-wf0.test.ts): parse the sibling maps/libs corpus, compile in-process, replay all 12,337 golden rows byte-identically; the adopting-maps manifest is honored; sibling-gated skip with aGOLDEN_ROOToverride. Harness detection was proven against a doctored golden (one flipped row → the failure names exactly that map) before the clean run.compile_itemgainsclass_ctx— constraint positions andany()alias arguments compile in CLASS context, where an imported charset alias resolving to a string expands per-character (rsconvert_class_alias; local string aliases stay sequences, capture innards stay sequence-resolved). Without it the ell lookbehinds compiled from a ~400-char literal sequence and could never match, silently disabling alalc-ell's medial γ rules.Verification
tests/test_golden_capture.pygreen on the real golden: 12,337/12,337 byte-identical through the in-process py runtime (83 s); pre-fix the in-process path diverged on exactly 5 rows (allalalc-ell-Grek-Latn-2010).from any(charset)single char; local-alias sequence preservation; the five ell rows + the word-final γκ guard through the full path).